Skip to content

Use GitHub action instead of npm package for code coverage upload#327

Merged
xlamorlette-datadog merged 1 commit into
mainfrom
xlamorlette/use-github-action-for-code-coverage-upload
Jun 11, 2026
Merged

Use GitHub action instead of npm package for code coverage upload#327
xlamorlette-datadog merged 1 commit into
mainfrom
xlamorlette/use-github-action-for-code-coverage-upload

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Little simplification: for code coverage upload, use the new dedicated GitHub action rather than the npm package.

Additional Notes

This is similar to DataDog/httpd-datadog#49.

@pr-commenter

pr-commenter Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-10 13:58:17

Comparing candidate commit 4e60b08 in PR branch xlamorlette/use-github-action-for-code-coverage-upload with baseline commit 2952e1f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 10, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 91.51% (+0.46%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4e60b08 | Docs | Datadog PR Page | Give us feedback!

@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/use-github-action-for-code-coverage-upload branch from f3879eb to 00190e0 Compare June 10, 2026 12:53
@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/use-github-action-for-code-coverage-upload branch from 00190e0 to 8955b26 Compare June 10, 2026 13:15
@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/use-github-action-for-code-coverage-upload branch from 8955b26 to 4e60b08 Compare June 10, 2026 13:52
@xlamorlette-datadog xlamorlette-datadog marked this pull request as ready for review June 10, 2026 14:23
@xlamorlette-datadog xlamorlette-datadog requested review from a team as code owners June 10, 2026 14:23
@xlamorlette-datadog xlamorlette-datadog requested review from cataphract and removed request for a team June 10, 2026 14:23
@xlamorlette-datadog xlamorlette-datadog merged commit d0605a7 into main Jun 11, 2026
67 of 68 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/use-github-action-for-code-coverage-upload branch June 11, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@cataphract cataphract Awaiting requested review from cataphract cataphract is a code owner automatically assigned from DataDog/dd-trace-cpp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xlamorlette-datadog @zacharycmontoya